Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python2 for webview #981

Merged
merged 4 commits into from
Aug 20, 2017
Merged

Fix python2 for webview #981

merged 4 commits into from
Aug 20, 2017

Conversation

KeyWeeUsr
Copy link
Contributor

new env var ANDROID_UNPACK to target a folder /data/data/<app>/files and for sdl2 that + /app to get libpymodules.so

@KeyWeeUsr
Copy link
Contributor Author

@brussee If you can, please review the new variable in the service_only bootstrap. I'm not sure if I got it right.

@inclement
Copy link
Member

Looks good, but I'll try some test builds before merging.

Would you mind also changing ANDROID_UNPACK to something like androidUnpack in the java code parts of the service_only bootstrap? It seems like that would match the java style better.

@inclement
Copy link
Member

I think this may have some problems with the python3 build, so I've temporarily reverted the change to custom-loader.patch to use ANDROID_APP_PATH instead (so that everything except the launcher works).

@kollivier
Copy link
Contributor

Has anyone tested the webview backend since the revert? I've cleaned everything, made sure the reverted code is in my tree, and rebuilt, but I'm still getting the 'module is 0 bytes' error when building a pretty simple app with webview. (I'm building with pyjnius and android modules)

new env var ANDROID_UNPACK to target a folder '/data/data/<app>/files' and for sdl2 that + '/app' to get libpymodules.so
@inclement inclement merged commit a7a878b into kivy:master Aug 20, 2017
@inclement
Copy link
Member

All merged, with a couple of other fixes! Thanks again KeyWeeUsr, I'm ashamed for the long time taken to pull it all together :<

These changes now mean that all the primary bootstraps seem to work for me.

@KeyWeeUsr KeyWeeUsr deleted the fix_python2sdl2 branch December 8, 2018 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants